Skip to content

ci: Add python linters for reverse dependency testing#252

Open
justin-stephenson wants to merge 2 commits into
SSSD:masterfrom
justin-stephenson:ci_add_pylinters
Open

ci: Add python linters for reverse dependency testing#252
justin-stephenson wants to merge 2 commits into
SSSD:masterfrom
justin-stephenson:ci_add_pylinters

Conversation

@justin-stephenson

@justin-stephenson justin-stephenson commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

In some cases changes in the SSSD test framework code can cause python linters run in SSSD repo to fail such as mypy, this PR should catch this if it happens.

@gemini-code-assist

Copy link
Copy Markdown

Note

Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported.

@justin-stephenson

Copy link
Copy Markdown
Contributor Author

NOTE: To ensure CI 'system' tests will succeed, hold off on merging this PR until SSSD/sssd#8762 is merged to address the existing mypy faliures

@justin-stephenson justin-stephenson changed the title ci: Add python linters for reverse dependency testing DO NOT MERGE YET ci: Add python linters for reverse dependency testing Jun 3, 2026
@justin-stephenson justin-stephenson changed the title DO NOT MERGE YET ci: Add python linters for reverse dependency testing ci: Add python linters for reverse dependency testing Jun 5, 2026
@justin-stephenson

Copy link
Copy Markdown
Contributor Author

This is now ready for review.

@ikerexxe ikerexxe left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we move the GitHub Actions version update to a separate commit? It’ll help keep this change history clean and focused

@justin-stephenson

Copy link
Copy Markdown
Contributor Author

Can we move the GitHub Actions version update to a separate commit? It’ll help keep this change history clean and focused

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants